SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 3.1.12

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
96 18 0 0

Files

Class Bugs
org.apache.johnzon.core.AbstractJsonFactory 1
org.apache.johnzon.core.JsonBuilderFactoryImpl 1
org.apache.johnzon.core.JsonChars 1
org.apache.johnzon.core.JsonGeneratorFactoryImpl 2
org.apache.johnzon.core.JsonGeneratorImpl 4
org.apache.johnzon.core.JsonNumberImpl 1
org.apache.johnzon.core.JsonObjectImpl 2
org.apache.johnzon.core.JsonProviderImpl 4
org.apache.johnzon.core.JsonStringImpl 1
org.apache.johnzon.core.Snippet$Buffer$SnippetWriter 1

org.apache.johnzon.core.AbstractJsonFactory

Bug Category Details Line Priority
new org.apache.johnzon.core.AbstractJsonFactory(Map, Collection, Collection) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 45 Medium

org.apache.johnzon.core.JsonBuilderFactoryImpl

Bug Category Details Line Priority
new org.apache.johnzon.core.JsonBuilderFactoryImpl(Map, BufferStrategy$BufferProvider, RejectDuplicateKeysMode, JsonProviderImpl) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 56 Medium

org.apache.johnzon.core.JsonChars

Bug Category Details Line Priority
org.apache.johnzon.core.JsonChars.EVT_MAP should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 80 Medium

org.apache.johnzon.core.JsonGeneratorFactoryImpl

Bug Category Details Line Priority
Class org.apache.johnzon.core.JsonGeneratorFactoryImpl defines non-transient non-serializable instance field buffer BAD_PRACTICE SE_BAD_FIELD Medium
Class org.apache.johnzon.core.JsonGeneratorFactoryImpl defines non-transient non-serializable instance field customBuffer BAD_PRACTICE SE_BAD_FIELD Medium

org.apache.johnzon.core.JsonGeneratorImpl

Bug Category Details Line Priority
Load of known null value in org.apache.johnzon.core.JsonGeneratorImpl.close() STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 455 Medium
org.apache.johnzon.core.JsonGeneratorImpl is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 41 Medium
Useless condition: it's known that c < 128 at this point STYLE UC_USELESS_CONDITION 538 High
Useless condition: it's known that c < 8192 (0x2000) at this point STYLE UC_USELESS_CONDITION 538 High

org.apache.johnzon.core.JsonNumberImpl

Bug Category Details Line Priority
org.apache.johnzon.core.JsonNumberImpl is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 29 Medium

org.apache.johnzon.core.JsonObjectImpl

Bug Category Details Line Priority
org.apache.johnzon.core.JsonObjectImpl.equals(Object) is unusual STYLE EQ_UNUSUAL 160 Medium
org.apache.johnzon.core.JsonObjectImpl is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 35 Medium

org.apache.johnzon.core.JsonProviderImpl

Bug Category Details Line Priority
Class org.apache.johnzon.core.JsonProviderImpl defines non-transient non-serializable instance field bufferProvider BAD_PRACTICE SE_BAD_FIELD High
Class org.apache.johnzon.core.JsonProviderImpl defines non-transient non-serializable instance field builderFactory BAD_PRACTICE SE_BAD_FIELD High
org.apache.johnzon.core.JsonProviderImpl$Cached stored into non-transient field JsonProviderImpl.bufferProvider BAD_PRACTICE SE_BAD_FIELD_STORE 56 High
org.apache.johnzon.core.JsonProviderImpl$Cached stored into non-transient field JsonProviderImpl.builderFactory BAD_PRACTICE SE_BAD_FIELD_STORE 64 High

org.apache.johnzon.core.JsonStringImpl

Bug Category Details Line Priority
org.apache.johnzon.core.JsonStringImpl is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 27 Medium

org.apache.johnzon.core.Snippet$Buffer$SnippetWriter

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.johnzon.core.Snippet$Buffer$SnippetWriter.get(): java.io.ByteArrayOutputStream.toString() I18N DM_DEFAULT_ENCODING 312 High